ActiveStorage image url isn't correct on localhost

[StephenFiser]

Image src is prefixed with http://example.org instead of http://localhost:3000.

[julianrubisch]

So I dug a bit into this. Surprisingly, even setting everything up in config/initializers/application_controller_renderer.rbdoesn't fix it:

ActiveSupport::Reloader.to_prepare do
  ApplicationController.renderer.defaults.merge!(
    http_host: 'localhost',
    https: false
  )
end

[1] pry(main)> ApplicationController.renderer
=> #<ActionController::Renderer:0x00007fc5a3b907d8
 @controller=ApplicationController,
 @defaults={:http_host=>"localhost", :https=>false, :method=>"get", :script_name=>"", :input=>""},
 @env={"HTTP_HOST"=>"example.org", "HTTPS"=>"off", "REQUEST_METHOD"=>"GET", "SCRIPT_NAME"=>"", "rack.input"=>"", "rack.url_scheme"=>"http"}>

As you can see it's present in @defaults, but not in @env['HTTP_HOST'].

So either I'm not understanding everything correctly (more likely) or this is a Rails bug.

[julianrubisch]

Interestingly, the rails code docs states:

# The template will be rendered in a Rack environment which is accessible through
--
  | # ActionController::Renderer#env. You can set it up in two ways:
  | #
  | # *  by changing renderer defaults, like
  | #
  | #       ApplicationController.renderer.defaults # => hash with default Rack environment
  | #
  | # *  by initializing an instance of renderer by passing it a custom environment.
  | #
  | #       ApplicationController.renderer.new(method: 'post', https: true)
  | #

so this should work?

[StephenFiser]

Thanks for taking a look into this. Apologies for not getting back to it. Been pretty tied up for the past week.

[julianrubisch]

So, apparently, thanks to @leastbad and @ParamagicDev on the StimulusReflex discord, setting

config.action_controller.default_url_options = {host: "localhost", port: 3000}

should do it. I suspected it had to be some of those config options, just it wasn't clear which default_url_options 😁

Could you try this and confirm? Then I'd update the docs and close the issue...

[julianrubisch]

@StephenFiser could you take a look if #50 looks good to you?

[leastbad]

This might be interesting to you, @StephenFiser https://discordapp.com/channels/629472241427415060/733725826411135107/754809268917502084

[StephenFiser]

@leastbad thanks for sharing! Totally fell off the wagon on this ticket 😬 Been swamped with unrelated items.