Opt out of restoring placeholders for a promoted TF navigation #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
Description
When navigating a part of the page using Turbo Frames, in case of promoting to a normal page visit, the placeholders would be replaced but never resolve again.
The reason for this is that the
turbo:before-cache
event fires on a regular visit, so placeholders will be restored in order to be put into the Turbo cache afterwards. Contrary to a regular page visit, though, the whole page body will not be replaced, so the placeholders remain unresolved.This would have been an easy fix if the
turbo:before-cache
event would have exposed anevent.detail
pointing to something usable, like the targeted Turbo Frame. Since it does not, however, I have come up with the following solution:turbo:before-fetch-request
event, the requested Turbo Frame ID is stored in thesessionStorage
restorePlaceholders
callback triggered byturbo:before-cache
will return early if such an identifier is present, then delete itThis could potentially lead to some race conditions, but since this should be tab-isolated, I think it's pretty safe.
Reproduction repository here: https://github.com/julianrubisch/futurism_turbo_frame_placehoder