Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bug report template to feature 'Futurism' #33

Merged
merged 2 commits into from
Jul 26, 2020

Conversation

marcoroth
Copy link
Member

@marcoroth marcoroth commented Jul 26, 2020

Type of PR

Fix

Description

Update the bug report template to feature Futurism and CableReady.

Why should this be added

No confusion when someone tries to file a bug 😉
Plus it could be good to know what version of CableReady is being used since they are "heavily related".

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing

@julianrubisch
Copy link
Contributor

Awesome! Another oversight of mine

Copy link
Contributor

@julianrubisch julianrubisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only question is whether SR is necessary as it isn’t a dependency?

@marcoroth
Copy link
Member Author

This is true, that's why I wrote "heavily related". But I'm happy to remove it if you feel it's out of place.

@julianrubisch
Copy link
Contributor

I‘d rather remove it so as to not add to the confusion. I also believe SR bugs have to be resolved there and this will only lead people to file bugs in the wrong place maybe?

@marcoroth
Copy link
Member Author

Sure! I removed it and updated the PR description 👍

@julianrubisch julianrubisch merged commit b9eee2d into stimulusreflex:master Jul 26, 2020
@marcoroth marcoroth deleted the bug-template branch July 26, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants