Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for pulling the user id out of session storage #238

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Conversation

mtomov
Copy link
Contributor

@mtomov mtomov commented Jun 19, 2020

Type of PR (feature, enhancement, bug fix, etc.)

documentation

Description

The auth guide is great! Thank you for that.

I am using Sorcery for authentication, where the user_id is stored in a session, and not in a cookie, which might be the case for other authentication libraries. It took me a bit of searching to understand how to access the session from the Action Cable connection.

Why should this be added

Save time for other users with user_id in session storage.

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing

* works for authentication libraries, such as Sorcery
@mtomov mtomov changed the title Add instructions on pulling the user id out of session storage Add instructions for pulling the user id out of session storage Jun 19, 2020
@leastbad leastbad merged commit 72ab1a4 into stimulusreflex:master Jun 19, 2020
@leastbad
Copy link
Contributor

Let's do this! I'm going to go with it, but if I find out later that you're making this up, there's gonna be trouble. ;)

@leastbad
Copy link
Contributor

Sorry for the churn. I accidentally ruined my morning by merging this. GitBook attempts to auto merge. Stay tuned.

@leastbad
Copy link
Contributor

Sorry for the revert revert shit show. I think everything is good now, except for the whole part where I probably denied @mtomov credit.

Long story short: if you ever merge in something that touches a documentation page while there are active drafts, GitBook shits the bed and treats the entire document as a series of merge conflicts. Regardless of which source you choose, you still end up with two copies of everything. It's like they never tested the feature.

@mtomov
Copy link
Contributor Author

mtomov commented Jun 19, 2020 via email

@mtomov mtomov deleted the patch-1 branch June 20, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants