Do not run sanity check on rails generate stimulus_reflex:config
#362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RolandStuder
force-pushed
the
allow-generate-on-failed-sanity-check
branch
from
147a28f to
985f96e
Compare
marcoroth
reviewed
Nov 13, 2020
RolandStuder
force-pushed
the
allow-generate-on-failed-sanity-check
branch
from
652cb51 to
79105f2
Compare
If a sanity check fails, the user gets a hint to create the configuration file with `rails generate stimulus_reflex:config`, however this command will also fail because it will also run the sanity check. Therefore we have to bypass the sanity check if the caller is a `generate_command`. Co-authored-by: Marco Roth <marco.roth@intergga.ch>
RolandStuder
force-pushed
the
allow-generate-on-failed-sanity-check
branch
from
79105f2 to
0f8aecf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a sanity check fails, the user gets a hint to create the configuration file with
rails generate stimulus_reflex:config, however this command will also fail because itwill also run the sanity check. Therefore we have to bypass the sanity check if
the caller is a
generate_command.Why should this be added
We should add this, as the idea of the whole sanity check is to help people. But if the command we recommend fails, we might be just causing more grief.
Checklist