Add tests for broadcasters #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianrubisch
force-pushed
the
test-broadcasters
branch
from
e127523 to
7ed33da
Compare
hopsoft
reviewed
Nov 17, 2020
julianrubisch
force-pushed
the
test-broadcasters
branch
3 times, most recently
from
44c33ab to
55313ea
Compare
julianrubisch
force-pushed
the
test-broadcasters
branch
from
d854d09 to
14e4231
Compare
julianrubisch
commented
Nov 19, 2020
| @@ -8,7 +8,7 @@ def broadcast(selectors, data) | |||
|
|
|||
| return unless page_html.present? | |||
|
|
|||
| document = Nokogiri::HTML(page_html) | |||
| document = Nokogiri::HTML.parse(page_html) | |||
There was a problem hiding this comment.
I changed this because it's easier to stub - I think it should be just an alias?
hopsoft
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests Tests
Description
Add test coverage for broadcasters
Checklist
Please note that the best way to suggest changes or updates to the documentation is to join Discord and leave a note in the #docs channel. Any documentation updates posted as PRs cannot be accepted at this time. ❤️