non-SR cable_ready operation pass-through #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
hopsoft
approved these changes
Nov 26, 2020
julianrubisch
added a commit
to julianrubisch/stimulus_reflex
that referenced
this pull request
Dec 25, 2020
* Exit with nonzero status code * [nodoc] update changelog * GitBook: [master] 3 pages modified * [nodoc] update changelog * Handles to mitigate race conditions when running reflexes in quick succession on the same element (stimulusreflex#377) * element.reflexData becomes a dictionary Co-authored-by: leastbad <hello@leastbad.com> * [nodoc] update changelog * fixed bug preventing callbacks for multiple morphs * [nodoc] update changelog * GitBook: [master] 5 pages modified * GitBook: [master] one page modified * GitBook: [master] one page modified * [nodoc] update changelog * GitBook: [master] one page modified * [nodoc] update changelog * make element.reflexController a dictionary (stimulusreflex#379) make element.reflexController a dictionary * [nodoc] update changelog * Move package.json to root of project (stimulusreflex#380) * Move package.json to root of project * Update readme instructions for publish * [nodoc] update changelog * Prep for v3.4.0.pre5 release * Update to use gitcdn for logo on readme * Bump js package version * Return from received if isolationMode: true * [nodoc] update changelog * GitBook: [master] one page modified * [nodoc] update changelog * non-SR cable_ready operation pass-through (stimulusreflex#381) * works like a charm * a superior solution * [nodoc] update changelog * Set reflexController to empty object * 800 * [nodoc] update changelog * GitBook: [master] one page modified * [nodoc] update changelog * don't show findElement warnings unless debugging (stimulusreflex#384) * dont exit in sanity checker on stimulus_reflex:install * split SR operations from data.operations (stimulusreflex#385) * [nodoc] update changelog * [nodoc] update changelog * add jQuery support to SR events (stimulusreflex#388) * Update templates for new stage etc (stimulusreflex#390) * updated templates for new lifecycle stages * added accessors to Reflex class * [nodoc] update changelog * reflexError and received refactor (stimulusreflex#389) * reflexError and received refactor * strict equality checks + simpler existential checks * Setup a proxy object that wraps CableReady::Channels (stimulusreflex#382) Setup a proxy object that wraps CableReady::Channels This improves developer ergonimics for emitting CR broadcasts on the SR channel within a reflex. * Remove codeclimate * [nodoc] update changelog * Add codacy config file * [nodoc] update changelog * Have codacy ignore markdown files * Allow `success` and `after` lifecycle methods on replaced elements (stimulusreflex#386) * Allow `success` and `after` lifecycle methods on replaced elements * use destruction syntax * Extract current debug setting into debug.js to sync the value between files * Log warnings if users morphs the element which triggered the reflex. * Log extra warning if the element is not present anymore to state, that the lifecycle methods were not executed * standardize * Tweaked wording slightly * added reflexError handling to dispatchLifecycleEvent Co-authored-by: leastbad <38150464+leastbad@users.noreply.github.com> Co-authored-by: leastbad <hello@leastbad.com> * [nodoc] update changelog * Prep for 3.4.0.pre6 release * [nodoc] update changelog * Update js package version * [nodoc] update changelog * Update %file_name%_reflex.rb.tt * Update stimulus_reflex.js * [nodoc] update changelog * Update lifecycle.js * tweaked life-cycle messages * Add check to return early if element is undefined in invokeLifecycleMethod * don't warn folks twice (stimulusreflex#392) * [nodoc] update changelog * [nodoc] update changelog * Update stimulus_reflex.rb * [nodoc] update changelog * GitBook: [master] 12 pages and 11 assets modified * Trigger piggy back operations after SR operations (stimulusreflex#395) * Trigger piggy back operations after SR operations * Refactor proxy object to be explicit about what is delegated. * Update to latest CableReady * [nodoc] update changelog * Prep for 3.4.0.pre7 * [nodoc] update js package version to 3.4.0-pre7 * GitBook: [master] 3 pages modified * [nodoc] update changelog * GitBook: [master] one page modified * [nodoc] update changelog * GitBook: [master] one page modified * [nodoc] update changelog * Delegate render to controller (stimulusreflex#397) * Delegate render to controller * Stand up basic testing for reflex rendering * Delegate render to the controller class rather than instance * Also, refactor some internals to match Rails internals. * [nodoc] update changelog * [nodoc] prepare for pre8 * [nodoc] update js package to pre8 * GitBook: [master] 14 pages modified * [nodoc] update changelog * GitBook: [master] one page modified * [nodoc] update changelog * GitBook: [master] 14 pages modified * [nodoc] update changelog * GitBook: [master] 14 pages modified * [nodoc] update changelog * loosen stimulus dev dependency * GitBook: [master] 4 pages modified * [nodoc] update changelog * GitBook: [master] 11 pages modified * [nodoc] update changelog * GitBook: [master] 2 pages modified * [nodoc] update changelog * GitBook: [master] 14 pages modified * GitBook: [master] 2 pages modified * GitBook: [master] one page modified * an install that actually works on a fresh Rails new * GitBook: [master] one page modified * [nodoc] update changelog * Don't memoize the singleton (stimulusreflex#400) * [nodoc] update changelog * GitBook: [master] 2 pages modified * [nodoc] update changelog * Add dom_id to the reflex (stimulusreflex#405) * [nodoc] update changelog * Check package version from yarn.lock if node_modules folder is not available. Fixex stimulusreflex#402 (stimulusreflex#403) * [nodoc] update changelog * Don't run sanity checker in production (stimulusreflex#404) * Allow StimulusReflex to process Rack middlewares (stimulusreflex#399) * Allow StimulusReflex to process Rack middleswares * Possibly fixes stimulusreflex#289 * process the whole Rails middleware stack * just call the Rails middleware stack if it reponds to `build` * pass routes to middleware build method * make middleware processing configurable * use ActionDispatch::MiddlewareStack to register middlewares * update comment in initializer * add note so people know what to do if they encounter the 'No route matches' error * Update channel.rb * Update stimulus_reflex.rb Co-authored-by: leastbad <38150464+leastbad@users.noreply.github.com> * [nodoc] prep for v3.4.0.pre9 * [nodoc] update js package version * GitBook: [master] one page modified * [nodoc] update changelog * GitBook: [master] 2 pages modified * [nodoc] update changelog * GitBook: [master] one page modified * [nodoc] update changelog * GitBook: [master] one page modified * GitBook: [master] one page modified * [nodoc] update changelog * GitBook: [master] one page modified * [nodoc] update changelog * GitBook: [master] one page modified * [nodoc] update changelog * GitBook: [master] one page modified * [nodoc] update changelog * GitBook: [master] one page modified * [nodoc] update changelog * Update README.md * [nodoc] update changelog * GitBook: [master] one page modified * [nodoc] update changelog * GitBook: [master] 2 pages modified * [nodoc] update changelog * GitBook: [master] one page modified * [nodoc] update changelog * GitBook: [master] one page modified * [nodoc] update changelog * [nodoc] prep for v3.4.0 * [nodoc] update npm package version * GitBook: [master] one page modified * [nodoc] update changelog * GitBook: [master] one page modified * [nodoc] update changelog * GitBook: [master] one page modified * [nodoc] update changelog * GitBook: [master] one page modified * GitBook: [master] one page modified * [nodoc] update changelog * fix 'operartion' typo * [nodoc] update changelog * Update README.md Co-authored-by: leastbad <38150464+leastbad@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions@example.com> Co-authored-by: leastbad <hello@leastbad.com> Co-authored-by: Rafe Rosen <rafe@hey.com> Co-authored-by: Nate Hopkins <natehop@gmail.com> Co-authored-by: Marco Roth <marco.roth@intergga.ch> Co-authored-by: Roland Studer <roland.studer@gmail.com> Co-authored-by: Josh LeBlanc <jleblanc@hey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR (feature, enhancement, bug fix, etc.)
Enhancement-ish
Description
CableReady operations that are piggybacked on the SR ActionCable channel are now executed.
Why should this be added
No need to create an additional channel to handle CableReady updates. Automatically sends to the correct user.
Checklist