Mutation observer wouldn't fire in certain situations #479
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain situations where you're morphing an element that does not contain a data-reflex attribute, the mutation observer wouldn't fire.
Type of PR (feature, enhancement, bug fix, etc.)
bug fix
Description
The attributeFilter option of mutation observer checks that any changed element has any attribute in the list of filters. If you morph an element without a
data-reflex
attribute, this mutation observer won't fire.@leastbad's note: adding
actionAttribute
to the list of observed attributes is a viable solution becausesetupDeclarativeReflexes
adds__perform
, a private/internal action. This makes it a reliable litmus test for the edge case this PR addresses.Checklist