Always pick up instance variables when accessing controller #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leastbad
changed the title
leastbad
changed the title
Closed
|
LGTM, would be cool if @jonsgreen could cross check |
|
FWIW I did run the MVCE he provided, so hopefully he can verify! |
|
@leastbad @julianrubisch I have also now confirmed that this is fixed on my MVCE. Thanks you for attending to these bugs on top of all the great feature work, documentation and support communication! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR (feature, enhancement, bug fix, etc.)
Bug fix
Description
Changes
Reflex#controllerso that it adds any ivars to the controller instance, even if it's been previously memoized.Fixes #471
Why should this be added
Since
controlleris memoized, if it is called in abefore_reflexcallback, any instance variables set in the main Reflex method will not be present in the controller when the page is rendered.Checklist