Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR (feature, enhancement, bug fix, etc.)
Enhancement
Description
SR now logs errors to
StimulusReflex.config.logger
, which defaults toRails.logger
but can be set in the SR initializer.debug
info
warn
error
fatal
unknown
are all supported.This PR should be completely transparent to most developers, except that they will now see Reflex logs (at
info
log level) in their Rails log.Why should this be added
The SR Logger class inexplicably used
puts
instead of writing to the Rails logger. This had the effect of making it so that Reflex "logs" show up in the server output even if logs are disabled, but don't show up in Rails logs even if logs are enabled. This is dumb!Checklist