introduce operations option for SR initialize #614
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR (feature, enhancement, bug fix, etc.)
Bug fix + enhancement
Description
Introduces a new option to
StimulusReflex.initialize
,operations
, which is used to override framework default CableReady operations for morph and replace tasks. The operations will default tomorph
andinner_html
unless specified. Note that the default morph task is likely to becomemorphdom
before SR 3.5 ships.Why should this be added
This should have been done with #599, which is currently broken. If the default operations are changed via the SR initializer, the Reflex is successfully created and executed on the server, but the event listeners were hard-coded to operate on
morph
andinnerHtml
operations. No client-side updates are possible in this scenario.I will go back to update the README on the previous PR to reflect the need to pass an
operations
object when this PR is merged.Checklist