Emit stimulus-reflex:ready
event on element instead of document
#625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Enhancement
Description
Previously the
stimulus-reflex:ready
was invoked every time thescanForReflexes()
function was called. With the recent changes of being able to load Stimulus controllers async we can't guarantee that thestimulus-reflex:ready
was always triggered at the right moment in time and it wasn't guaranteed that all controllers were actually loaded and registered.Since we can't guarantee that the "whole document and all controllers are loaded and ready", we instead emit an event on the actual element that we know that it is ready and was setup for sure.
Resolves #608
Why should this be added
Consistently and better support for asynchronous loading of Stimulus controllers.
Checklist