Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Deep merge url_params in ReflexData #647

Merged
merged 2 commits into from
Mar 22, 2023
Merged

fix: Deep merge url_params in ReflexData #647

merged 2 commits into from
Mar 22, 2023

Conversation

julianrubisch
Copy link
Contributor

Type of PR

Bug Fix

Description

Discord user laykou reported a case in which url_params in ReflexData were overriding form_params when having the same key.

This is solved here by deep_mergeing them.

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing

@julianrubisch julianrubisch self-assigned this Mar 20, 2023
@netlify
Copy link

netlify bot commented Mar 20, 2023 •
edited
Loading

✅ Deploy Preview for stimulusreflex ready!

Name Link
🔨 Latest commit ec757e6
🔍 Latest deploy log https://app.netlify.com/sites/stimulusreflex/deploys/64185dbc7213720008f7f644
😎 Deploy Preview https://deploy-preview-647--stimulusreflex.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julianrubisch julianrubisch added bug Something isn't working ruby Pull requests that update Ruby code labels Mar 20, 2023
@julianrubisch julianrubisch requested a review from marcoroth March 20, 2023 13:18
marcoroth
marcoroth approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

It probably wouldn't hurt if we add more tests for the ReflexData class in general at some point!

@julianrubisch julianrubisch merged commit 02a8761 into main Mar 22, 2023
@julianrubisch julianrubisch deleted the reflex-data-deep-merge branch March 22, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hopsoft hopsoft hopsoft approved these changes

@marcoroth marcoroth marcoroth approved these changes

Assignees

@julianrubisch julianrubisch

Labels
bug Something isn't working ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianrubisch @hopsoft @marcoroth