Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reflex_data keyword argument #673

Merged
merged 2 commits into from
Nov 26, 2023

Conversation

brunoenten
Copy link
Contributor

Type of PR (feature, enhancement, bug fix, etc.)

bug fix

Description

Rename named parameter, and change error message that was causing an exception in a rescue block.

Why should this be added

Stimulus reflex doesn't work at all without these fixes.

Checklist

  • [X ] My code follows the style guidelines of this project
  • [ X] Checks (StandardRB & Prettier-Standard) are passing

Rename named parameter, and change rescue error message
@netlify
Copy link

netlify bot commented Oct 8, 2023

Deploy Preview for stimulusreflex ready!

Name Link
🔨 Latest commit 09cadff
🔍 Latest deploy log https://app.netlify.com/sites/stimulusreflex/deploys/653781bc0f94c80009561e50
😎 Deploy Preview https://deploy-preview-673--stimulusreflex.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marcoroth marcoroth changed the title fix breaking issues Fix reflex_data keyword argument Nov 26, 2023
Copy link
Member

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @brunoenten!

@marcoroth marcoroth merged commit 208409e into stimulusreflex:main Nov 26, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants