feat(pubsub): Add shared context among Redis instances

[fersilva16]

I'm continuing the #997.

• Create a shared expires instance for context
• Create a shared data instance for context

Closes #997 and #773

[stipsan]

This is fantastic! Let's roll it out! 🥳

[stipsan]

I'll release this as soon as the tests pass, and change the commit to use feat instead of fix as I consider this new functionality ☺️

[stipsan]

Just did a local checkout to run the test suite, and I'm getting the same failing tests as https://github.com/stipsan/ioredis-mock/runs/4892890568?check_suite_focus=true#step:4:11167

@fersilva16 are you able to run through the test suite?

[fersilva16]

are you able to run through the test suite?

No, my tests are failing too, I'm implemented the shared expires/data and it fixes almost all broken tests, but I'm still working on the rest of the tests, some of them need a refactor.

[stipsan]

are you able to run through the test suite?

No, my tests are failing too, I'm implemented the shared expires/data and it fixes almost all broken tests, but I'm still working on the rest of the tests, some of them need a refactor.

Alright, let us know if there's anything we can do to help ☺️

[fersilva16]

Now the tests should pass. And should I rebase the commits to one commit only?

[stipsan]

Now the tests should pass. And should I rebase the commits to one commit only?

Awesome! 🥳 Rebase or not is entirely up to you, as all PRs are squash & merged anyways 😌

[fersilva16]

I think it's done now! 🥳🎉

[stipsan]

I think it's done now! 🥳🎉

Thank you so much @fersilva16! 🥳 this is fantastic, and I know a lot of people have been waiting for this! (Especially @sibelius) 😄

[stipsan]

The error on the CI seems to be related to an error I saw on an another PR earlier today: #1106 (comment)

[sibelius]

it is happening

[fersilva16]

Fixed!

[stipsan]

🎉 This PR is included in version 5.9.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀