Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ACF block & component integration #11

Open
brianjohnhanna opened this issue Jul 30, 2021 · 0 comments
Open

Improve ACF block & component integration #11

brianjohnhanna opened this issue Jul 30, 2021 · 0 comments

Comments

@brianjohnhanna
Copy link
Collaborator

brianjohnhanna commented Jul 30, 2021 •
edited
Loading

As part of #7 we added the ability to share component templates with the block editor using ACF blocks. However, the experience is a little buggy and needs further fine-tuning.

We should, at minimum:

  • determine whether a config file (currently config/blocks.php) is the best way register/store an array of components to share and, if so, whether the array should be included in a different config file.
  • explore a CLI script to bootstrap new components so they are properly setup to work as blocks as well
  • test and troubleshoot all existing components to ensure they are block-compatible, even if they aren't registered by default
  • update the block descriptions and icons for each of our custom blocks
brianjohnhanna added a commit that referenced this issue Jul 30, 2021
@brianjohnhanna
Remove block registration and specify details in comment
64e8507 
See #11 for more info
brianjohnhanna added a commit that referenced this issue Jul 30, 2021
@brianjohnhanna
Register Starter ACF Fields with Corresponding Bootstrap Components (#7)
fadb90b 
* Setup fields builder and front-page, page and component field templates

* Fix bug in Sage ACF Blocks

MWDelaney/sage-acf-wp-blocks#52 (comment)

* Update accordion and tab components and blocks

* Add blocks config file

* Add automatic registration of blocks connected to component fields

* Add correct version of sage blocks plugin

* Add additional components and refactor existing

* Add options page

* Update filters, add display_sidebar

* Add default BS4 gravity forms styling

* Include baseline swiper styles

* Refactor default layouts and templates, add kitchen sink

* Update swiper language to represent carousels/sliders

* Update components and kitchen sink

* Add link for sage acf block fix

* Remove duplicate footer element

* Add CLI stubs

* Add CLI script for insering dummy data into kitchen sink template

* Add default card imge style

* Update swiper styles

* Update layout of kitchen sink page

* Remove $test variable

* Refactor card field structure

* Programatically add a menu via demo CLI script

* Add alert component and refactor quicklinks

* Remove block registration and specify details in comment

See #11 for more info

* Update default page settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brianjohnhanna