Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tip about error to google-sheets-v1.md #532

Merged
merged 2 commits into from
Aug 27, 2020

Conversation

shedd
Copy link
Contributor

@shedd shedd commented Aug 3, 2020

@cmerrick
Copy link
Contributor

cmerrick commented Aug 3, 2020

Hi @shedd, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Contributor

cmerrick commented Aug 3, 2020

You did it @shedd!

Thank you for signing the Singer Contribution License Agreement.

@erinkcochran87
Copy link
Contributor

Hey @shedd! Thanks so much for contributing this. I recently made some changes to the master branch to get around some issues our CDN was having with building the site. Could you please update this branch from master and re-commit so I can make sure it builds before I merge it?

shedd and others added 2 commits August 20, 2020 16:10
Add a note about [the file not found error that occurs when attempting to load a Google Sheet from a shared drive](singer-io/tap-google-sheets#7).
Cleaning up copy to fit our style guidelines. Also added this info to the Feature Summary > Limitations, and the Setup Prerequisites sections.
@shedd
Copy link
Contributor Author

shedd commented Aug 20, 2020

@erinkcochran87 sure, I've rebased it

@erinkcochran87
Copy link
Contributor

Looks good - merging!

@erinkcochran87 erinkcochran87 merged commit c561fde into stitchdata:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants