-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve] Improved Docker build #514
base: main
Are you sure you want to change the base?
Conversation
This commit provides an improved Docker build. 1. Adds and configures Miniconda environment with GPU drivers support. 2. Adds ability to sync local and Docker environments with Conda and environment.yml. 3. Fixes container communication issues 4. Adds name to `devika-backend-engine` service image 5. Adds hostnames additionally to service names to simplify containers communication by shorter and convenient host names. 6. Implements various environment variables for optimization. 7. Patches source files on image build for seamless Docker support 8. Replaces UI package manager with Yarn, which does not require additional installation 9. Replaces base UI image to `node:18.20.2-bullseye` which provides Node out-of-the-box. 10 Replaces base image of backend service to `python:3.11.9-bookworm` with Python 3.11 preinstalled.
This commit can be safely discarded.
remove the lock file |
also how much each the size of the containers? |
Thanks for the prompt reply, @ARajgor! Preparing another commit with hotfixes. |
devika-backend-engine-1 | Traceback (most recent call last): |
I'm not sure if this is related to this specific PR. |
|
@ARajgor docker-compose build should run smoothly now |
you didn't remove the yarn.lock |
|
devika is using bun as it default package manager. bun.lockb is already included in the repo. |
@nalaso, the reasoning is mentioned in the PR description: |
how about using oven/bun? also the app can work with just Bun |
No problem about Bun.
This is based on my project, which uses Yarn as a package manager. Feel
free to replace it with Bun or anything.
…On Thu, May 2, 2024 at 11:45 AM Polygons1 ***@***.***> wrote:
how about using oven/bun? also the app can work with just Bun
—
Reply to this email directly, view it on GitHub
<#514 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMYTLKG2NQ7EJALMLG54TKTZAH4J5AVCNFSM6AAAAABG7RHPVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBZHEZDAMJUHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This commit provides an improved Docker build
environment.yml
.devika-backend-engine
service image.node:18.20.2-bullseye
, which provides the node out-of-the-box.python:3.11.9-bookworm
with Python 3.11 preinstalled.