Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include >=v1.2 structs in SectionOrdering rule #202

Open
a-frantz opened this issue Sep 30, 2024 · 6 comments
Open

include >=v1.2 structs in SectionOrdering rule #202

a-frantz opened this issue Sep 30, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@a-frantz
Copy link
Member

a-frantz commented Sep 30, 2024

The SectionOrdering lint rule should be updated to account for the optional meta and parameter_meta sections which were introduced to struct definitions in v1.2 of the WDL specification.

The order should be meta -> parameter_meta -> declarations.

@a-frantz a-frantz added enhancement New feature or request good first issue Good for newcomers labels Sep 30, 2024
@bhartiRaz
Copy link

"Hello, @a-frantz could you please assign this issue to me?"

@a-frantz
Copy link
Member Author

a-frantz commented Mar 1, 2025

Sure thing! @bhartiRaz

@bhartiRaz
Copy link

Thanks, @a-frantz! I'll start working on this.

@bhartiRaz
Copy link

Hello @a-frantz , I am a little new to the code base, could you please clarify where to look for the code, and elaborate further? Thankyou!

@claymcleod
Copy link
Member

I agree that this issue is not clear on what needs to happen. @a-frantz, please add more details.

When it does come time to implement it, you'll be looking at this file @bhartiRaz: https://github.com/stjude-rust-labs/wdl/blob/main/wdl-lint/src/rules/section_order.rs.

@a-frantz
Copy link
Member Author

a-frantz commented Mar 1, 2025

@bhartiRaz I've updated the issue to include some more detail.

You'll need to edit the section_order.rs file linked to above and also the section-ordering/source.wdl file to include example struct definitions which both do and do not trigger the modified lint rule.

Check the FAQ section of the CONTRIBUTING guide for some more direction. And you can see the linked section of the WDL spec to see how structs should be defined in the example WDL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants