-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include >=v1.2 structs in SectionOrdering rule #202
Comments
"Hello, @a-frantz could you please assign this issue to me?" |
Sure thing! @bhartiRaz |
Thanks, @a-frantz! I'll start working on this. |
Hello @a-frantz , I am a little new to the code base, could you please clarify where to look for the code, and elaborate further? Thankyou! |
I agree that this issue is not clear on what needs to happen. @a-frantz, please add more details. When it does come time to implement it, you'll be looking at this file @bhartiRaz: https://github.com/stjude-rust-labs/wdl/blob/main/wdl-lint/src/rules/section_order.rs. |
@bhartiRaz I've updated the issue to include some more detail. You'll need to edit the Check the FAQ section of the CONTRIBUTING guide for some more direction. And you can see the linked section of the WDL spec to see how structs should be defined in the example WDL. |
The
SectionOrdering
lint rule should be updated to account for the optionalmeta
andparameter_meta
sections which were introduced tostruct
definitions in v1.2 of the WDL specification.The order should be
meta -> parameter_meta -> declarations
.The text was updated successfully, but these errors were encountered: