Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new diagnostic for meaningless lint directive #204

Open
a-frantz opened this issue Oct 1, 2024 · 0 comments
Open

new diagnostic for meaningless lint directive #204

a-frantz opened this issue Oct 1, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@a-frantz
Copy link
Member

a-frantz commented Oct 1, 2024

Lint directives in the preamble should not fire this diagnostic. This is to support the "boilerplate" use case where someone just wants to blanket except certain rules for any WDL document.

Other lint directives that don't actually suppress anything should emit a note. Detecting this will involve tracking what rules are being called with exceptable_add() and then looking through the CST.

@a-frantz a-frantz added the enhancement New feature or request label Oct 1, 2024
@a-frantz a-frantz changed the title new diagnostic for meaningless litn directive new diagnostic for meaningless lint directive Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant