Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: properly map file/directory paths for task evaluation #267

Open
peterhuene opened this issue Dec 10, 2024 · 0 comments
Open

feature: properly map file/directory paths for task evaluation #267

peterhuene opened this issue Dec 10, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@peterhuene
Copy link
Collaborator

With the initial implementation of task evaluations in #265, only File/Directory values that are transitively referenced by the command get mapped into container environments.

This means that auxiliary inputs to a task, such as specifying a bai input that isn't referenced by the command directly, will not be mapped into the container environment; note that in wdl-analysis we have a heuristic to suppress unused inputs with specific suffixes (bai being one of them) for this reason as well.

While referencing a struct value that contains multiple files should map all of the structs paths, we should probably map, at the very least, all inputs along with any private declarations explicitly referenced by the command; alternatively, just map all inputs and all private declarations regardless of being referenced by the command.

@peterhuene peterhuene added the enhancement New feature or request label Dec 10, 2024
@peterhuene peterhuene self-assigned this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant