Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible CommandSection strip_whitespace regression, now removes the first word on the first line #268

Closed
thatRichman opened this issue Dec 13, 2024 · 1 comment · Fixed by #271
Assignees
Labels
bug Something isn't working

Comments

@thatRichman
Copy link

thatRichman commented Dec 13, 2024

I noticed this after I rebased #264 following the merge of #265 .

Take for example the following Command section:

command <<<      weird stuff $firstlinelint
            # other weird whitespace
      somecommand.py $line120 ~{placeholder}
>>>

The first StrippedCommandPart returned from strip_whitespace

Prior to c5c1553:

Text(
    "weird stuff $firstlinelint\n      # other weird whitespace\nsomecommand.py $line120 ",
)

after c5c1553:

Text(
    "stuff $firstlinelint\n      # other weird whitespace\nsomecommand.py $line120 ",
)

Was this intentional or is it a bug?

@thatRichman thatRichman changed the title Possible Task strip_whitespace regression, now removes the first word on the first line of a command section Possible CommandSection strip_whitespace regression, now removes the first word on the first line of a command section Dec 14, 2024
@thatRichman thatRichman changed the title Possible CommandSection strip_whitespace regression, now removes the first word on the first line of a command section Possible CommandSection strip_whitespace regression, now removes the first word on the first line Dec 14, 2024
@a-frantz a-frantz self-assigned this Dec 17, 2024
@a-frantz a-frantz added the bug Something isn't working label Dec 17, 2024
@a-frantz
Copy link
Member

Definitely a bug. Looking into it this morning. Thanks for catching this edge case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants