-
Notifications
You must be signed in to change notification settings - Fork 9
SC fixes #2763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SC fixes #2763
Conversation
…n singlecell plot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good. However, I noticed a layout issue: When viewing the UMAP and t-SNE plots side by side, then switching to the differential expression tab to run an analysis, the output table only takes up half of the sandbox width instead of the full width like the samples table does. While there's a resize handle in the corner of the table, it's not functional when dragged.
Thanks Andrew. I made the DE table resizable now. Also I have reduced the table heights for the GDC Frontend Framework as they add one extra heading and the long height on the tables makes them scroll |
You're welcome. The table can now be resized to be smaller or larger. I didn't realize there was a limit on the width of the DE table. At about ~half way across the page the table can't be made larger. My previous comment can be discarded as I thought the DE table could be expanded to fill the full width of the page but I see that isn't the case |
…rsor in toggleButtons render(); fix failing test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks @siosonel
Description
Do not preselect a sample but show only Samples tabs until a sample is selected. Improved sample heading. Aligned legend with plot for GDC. Added subtype in BALL sjpp. I used the idea about hiding other tabs that we discussed @siosonel to do as GDC asked.
Two plots in a row with the legend besides the plot:
Checklist
Check each task that has been performed or verified to be not applicable.