Skip to content

Commit

Permalink
use GMT timestamp for dynamic update
Browse files Browse the repository at this point in the history
Use real unix timestamps and do not rely on the system timezone. We now
query the "post_date_gmt" field and use timestamps without zone bias.
  • Loading branch information
stklcode committed Nov 24, 2019
1 parent 8103e78 commit e201d7c
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 6 deletions.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ However the AJAX update will fetch the latest ticks and update cached tickers d

## Changelog

### 1.1.0 - unreleased

* Use GMT for automatic updates

### 1.0.0 - 2018-11-02

* Initial release
2 changes: 1 addition & 1 deletion includes/class-scliveticker-widget.php
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public function widget( $args, $instance ) {
echo ' sclt-widget-ajax" '
. 'data-sclt-ticker="' . esc_attr( $category ) . '" '
. 'data-sclt-limit="' . esc_attr( $count ) . '" '
. 'data-sclt-last="' . esc_attr( current_time( 'timestamp' ) );
. 'data-sclt-last="' . esc_attr( current_datetime()->getTimestamp() );
}
echo '">';

Expand Down
24 changes: 19 additions & 5 deletions includes/class-scliveticker.php
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ public static function shortcode_ticker_show( $atts ) {
$output .= ' sclt-ticker-ajax" '
. 'data-sclt-ticker="' . $ticker . '" '
. 'data-sclt-limit="' . $limit . '" '
. 'data-sclt-last="' . current_time( 'timestamp' );
. 'data-sclt-last="' . current_datetime()->getTimestamp();
}
$output .= '">';

Expand Down Expand Up @@ -317,7 +317,13 @@ public static function ajax_update() {
}

$limit = ( isset( $update_req['l'] ) ) ? intval( $update_req['l'] ) : - 1;
$last_poll = ( isset( $update_req['t'] ) ) ? intval( $update_req['t'] ) : 0;
$last_poll = explode(
',',
gmdate(
'Y,m,d,H,i,s',
( isset( $update_req['t'] ) ) ? intval( $update_req['t'] ) : 0
)
);

// Query new ticks from DB.
$query_args = array(
Expand All @@ -331,7 +337,15 @@ public static function ajax_update() {
),
),
'date_query' => array(
'after' => date( 'c', $last_poll ),
'column' => 'post_date_gmt',
'after' => array(
'year' => intval( $last_poll[0] ),
'month' => intval( $last_poll[1] ),
'day' => intval( $last_poll[2] ),
'hour' => intval( $last_poll[3] ),
'minute' => intval( $last_poll[4] ),
'second' => intval( $last_poll[5] ),
),
),
);

Expand All @@ -351,13 +365,13 @@ public static function ajax_update() {
$res[] = array(
'w' => $slug,
'h' => $out,
't' => current_time( 'timestamp' ),
't' => current_datetime()->getTimestamp(),
);
} else {
$res[] = array(
's' => $slug,
'h' => $out,
't' => current_time( 'timestamp' ),
't' => current_datetime()->getTimestamp(),
);
}
}
Expand Down

0 comments on commit e201d7c

Please sign in to comment.