Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for embeded videos #9

Closed
nanu-c opened this issue May 1, 2020 · 2 comments
Closed

Support for embeded videos #9

nanu-c opened this issue May 1, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone
1.1

Comments

@nanu-c
Copy link

nanu-c commented May 1, 2020

Every ajax call re-renders all the ticks. If a youtube video is embedded it get's reloaded all the time.
@stklcode
Copy link
Owner

stklcode commented May 1, 2020 •
edited
Loading

Never thought of anybody embedding videos in a liveticker, but you're absolutely right.

The JS replaces the HTML content of the container to prepend pre-rendered ticks. This should be refactored to selectively append the children and not touching old content.

@stklcode stklcode added the enhancement New feature or request label May 1, 2020
@stklcode stklcode mentioned this issue May 1, 2020
Merged
@stklcode stklcode added this to the 1.1 milestone May 1, 2020
stklcode added a commit that referenced this issue May 1, 2020
@stklcode
prepend new elements instead of replacing HTML on AJAX update (#9) (#12)
6ed625d 
Replacing the body by prepending HTML results in the full content
being re-rendered. This can be a performance issue, but is definitely
annoying when embedding media in ticks.
stklcode added a commit that referenced this issue May 2, 2020
@stklcode
prepend new elements instead of replacing HTML on AJAX update (#9) (#12)
d75b790 
Replacing the body by prepending HTML results in the full content
being re-rendered. This can be a performance issue, but is definitely
annoying when embedding media in ticks.
@stklcode
Copy link
Owner

stklcode commented May 2, 2020

I've tested the modified update logic in v1.1.0 with an embedded Youtube video. New ticks get prepended before the video, but playback continues, Obviously if the video-tick is beyond the configured limit, it gets removed.

So I'd consider this issue done. If you still experience problems with embedded media, don't hesitate to give feedback.

@stklcode stklcode closed this as completed May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
2 participants
@nanu-c @stklcode