use time() instead of current_datetime() for WP 4.x compatibility #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function current_datetime() has been introduced in WP 5.3, but the Plugin should maintain compatibility with 4.x for now.
stklcode
added a commit
that referenced
this pull request
May 2, 2020
The function current_datetime() has been introduced in WP 5.3, but the Plugin should maintain compatibility with 4.x for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression from #3 (use GMT timestamp for dynamic update)
The function
current_datetime()has been introduced in WP 5.3, but the Plugin should maintain compatibility with 4.x for now. No idea why this has not been caught by PHPCS, but that's what manual testing is for...We now simply use PHP's
time()instead of reverting tocurrent_time( 'timestamp' )which is rather misleading.