Requiring executor tasks are noexcept. #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixPetriconi
approved these changes
Aug 17, 2023
This reverts commit 3e113b2.
Hit a weird issue with version 12 in forest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done with enable_if on the executors and adding the ability to declare a
task<>asnoexceptinvokable. I.e.,task<void(int) noexcept>.An alternative design was to use
static_assert()instead ofenable_if. The problem with that approach is a single mistake would trigger multiplestatic_assert()(all asserts along the instantiation path).Currently working on docs and updating hyde so this is a preview PR for comment.