namespace version bump #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm bumping the version to avoid ODR violations. I'm leaving the pre_exit code at v1 (it would have to be bumped more carefully). The portable default executor is getting bumped, which may lead to duplicates, which must be addressed more carefully. Removed dead reset() operations in future shared_base Documented (and assert) precondition that future::exception() is only invoked on a ready exception. Made more of the tuple meta-facilities public to avoid detail:: namespace usage in unit tests.
| @@ -7,6 +7,9 @@ | |||
| #ifndef STLAB_CONFIG_HPP | |||
| #define STLAB_CONFIG_HPP | |||
|
|
|||
| // Release version macro - used for inline namespace increment on each release | |||
There was a problem hiding this comment.
Do you want to add a comment here about not bumping pre_exit, and what "more carefully" entails? I saw it in the PR description and wonder if it should last longer than this PR...
There was a problem hiding this comment.
The comment is in pre_exit.hpp.
|
Change LGTM, with a minor nit. Thank you Sean for keeping on top of this issue! |
fosterbrereton
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping the inline namespace version to v2 to avoid ODR violations.
The
pre_exitcode remains atv1(it must be bumped more carefully).The portable default executor is moving to
v2- which may lead to more than one thread pool for the portable instance. Pinning the version here is more difficult.Removed dead
reset()operations in futureshared_baseDocumented (and assert) precondition that
future::exception()is only invoked on a ready exception.Made more of the tuple meta-facilities public to avoid
detail:: namespaceusage in unit tests.Restructured unit tests to avoid sleep-wait-loops.