Add STLAB_BUILD_LIBRARY CMake option to build a library #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we have moved to CMake I'm fine with moving away from a header only library so I removed the header-only option. I declared pre_exit and at_pre_exit as extern "C" to make them simpler to export from a DLL in an export list. I will open an issue to do a similar thing for the default executor, that is a bit more difficult pull because of late type erasure.
|
I removed the option for building header-only (it is now always building the .cpp files) to keep the build matrix simple. The pre_exit operations are extern "C" to make them simpler to add to an export list. I'll look to do something simlar for the default executor in another PR - that is more difficult because of the late type erasure. |
sean-parent
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a CMAKE option to be able to build a library with functions containing local static variables and avoid double definition of them when compiling shared libraries