Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cases for PR #153 in JSON-Java #28

Merged
merged 1 commit into from
Oct 29, 2015
Merged

Test cases for PR #153 in JSON-Java #28

merged 1 commit into from
Oct 29, 2015

Conversation

johnjaylward
Copy link
Contributor

This adds regression test cases for the Constructor and Put methods on JSONObject and JSONArray that should be run again JSON-Java commit stleary/JSON-java@48d31b7 or earlier as a base line.

Notes on running the tests:

  • The baseline commit should still be compiled on java1.5 or higher so that generics are supported. The baseline is just the last commit before generics were used in the code itself.
  • The tests will run unmodified on both the current master as well as on the PR branch
  • When running against the baseline commit, you will need to clean out newer tests, like the BigNumber support, the fixes for JSONML, etc that didn't exist at the time of the baseline.
  • The new regression tests I committed should pass for baseline and JSONObject and JSONArray initialization: JSON-java#153, but will fail on master

@stleary
Copy link
Owner

stleary commented Oct 14, 2015

Will try redirecting this into a branch so that unit test and JSON-java master branches stay compatible.

@stleary
Copy link
Owner

stleary commented Oct 16, 2015

Moved to branch https://github.com/stleary/JSON-Java-unit-test/tree/johnjaylward-FixCtorGenerics so that I could do some minor edits. I don't think any functionality is changed.

  • Tested with failures against JSON-java master. This was expected.
  • Tested successfully against JSONObject and JSONArray initialization: JSON-java#153.
  • Tested with failures against limited ctor change for 153 JSON-java#164. Analysis in progress. If the failed tests are all due to previously unsupported functionality, I will probably not be too concerned.
  • Tested against baseline. Ignored bigNumberOperations() and jsonObjectToStringSuppressWarningOnCastToMap(), which had compiler errors, and wrapObject(), which failed, I think due to testing a BigNumber. Other tests were all successful.

@johnjaylward
Copy link
Contributor Author

I updated my notes in the description. I was unsure is github notified of description changes.

@johnjaylward
Copy link
Contributor Author

For your failures on stleary/JSON-java#164, try making both Map generics ?.

i.e. Map<?,?>.

I believe your goal for pr 164 is to possibly replace 153. If that is the case, you will want all tests passing similarly to either BaseLine or pr153. No failures should be from "previous unsupported functionality" as pr164 is based off master.

@stleary
Copy link
Owner

stleary commented Oct 17, 2015

I was unsure if github notified of description changes.

As far as I can tell, it does not.

stleary added a commit that referenced this pull request Oct 29, 2015
Test cases for PR #153 in JSON-Java
@stleary stleary merged commit 6406c7a into stleary:master Oct 29, 2015
@johnjaylward johnjaylward deleted the FixCtorGenerics branch July 10, 2017 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants