Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make textKey (default "content") configurable in XML-JSON conversion #108

Closed
wants to merge 1 commit into from

Conversation

jnothman
Copy link

The special handling of the key "content" in XML.toString results in highly unexpected behaviour in practice. Here is a patch that allows this key to be configurable. Indeed, null is a good value for most cases, and I suggest it be made the default.

@douglascrockford
Copy link
Contributor

Please see the README.

@johnjaylward
Copy link
Contributor

@jnothman We finally got around to trying out more configuration for the XML parser. Please see PR #412 and let us know if it meets your needs. It was based on this PR, so it should be close. Thanks.

@jnothman
Copy link
Author

Sorry I'm not really available to comment. I can't recall the context in which I used this project.

@johnjaylward
Copy link
Contributor

Thanks anyway

@jnothman
Copy link
Author

I suppose that's a better response, at least, than Please see the README. I still can't see in the README of that time what I was possibly meant to see there.

@johnjaylward
Copy link
Contributor

johnjaylward commented Mar 22, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants