-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly overrides the Exception class. #159
Conversation
Can you say a few words about why this needs to be fixed? |
The Exception base class already has a variable to store the "cause" and the super.getCause() method already handles the cause properly. This pull request simplifies the implementation as well as creates less stack overhead when throwing an exception. |
Moved to a branch commit and pull request. Please see #161 |
I had already adjusted the date after seeing it modified in your PR. Not sure if that will affect the test. |
Completed unit tests successfully. No local changes needed. Will leave this pull request open for a few days for comment. This change does not change behavior or API, so will not result in a new release. |
What problem does this code solve? Changes to the API, code behavior, unit tests, or documentation? Will this require a new release? |
Properly overrides the Exception class.
Overriding the exception class should not keep it's own
cause
field.