Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comparison for
(object == null) ? "null" : escape(object.toString())
was doing nothing,escape(object.toString())
would always be called sinceobject
could never be null at this point. I have added a null check around the possible NPE areas so this check actually does something.If we want the NPE, then I propose we just change the
(object == null) ? "null" : escape(object.toString())
tertiary toescape(object.toString())