-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CSV change to CDL.java #219
Conversation
Looks reasonable. Need to run it through the unit tests, and add some cases to exercise the new code. @captainIowa you are welcome to take the lead on that if you want. The unit tests are located in https://github.com/stleary/JSON-Java-unit-test. Otherwise I will take care of it when I get a chance. |
@stleary I can take a run at it this weekend. |
@stleary I ran my changes through the unit tests and added some additional ones to exercise my code changes. Do I need to post the results of the unit tests somewhere or take any additional steps? |
@captainIowa thanks, no other actions are needed, reviewers will take a look and let you know if there are any concerns. |
The change looks good to me upon review. I did not check out and run the code myself though. As long as all the new tests pass, I think this is good to go. |
What problem does this code solve? Changes to the API? Does it break the unit tests? Will this require a new release? Should the documentation be updated? |
Adding my code for the GitHub issue I described.