Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for #340
What problem does this code solve?
This is a performance enhancement, not a bug fix. Some code is refactored to use new loop types and map iterators introduced in Java5. One assignment (line 541) was deleted from the XML class as it didn't do anything.
Risks
low
Changes to the API?
New protected method added for internal access to the backing map entrySet. I wasn't comfortable making this a public method without input from the community as it allows unfiltered access to the entire map (keys and values).
Will this require a new release?
No, can be rolled into the next release
Should the documentation be updated?
No
Does it break the unit tests?
No. Also, no unit tests have been added at this time.
Was any code refactored in this commit?
Yes
Review status
ACCEPTED. A few lines of new code in JSONArray and JSONObject are not tested, but this can be picked up in the next test refactoring. Starting 3 day timer for comments.