Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update javadoc according to issue #356. #357

Merged
merged 1 commit into from
Jul 15, 2017
Merged

Update javadoc according to issue #356. #357

merged 1 commit into from
Jul 15, 2017

Conversation

johnjaylward
Copy link
Contributor

javadoc only update.

@johnjaylward johnjaylward mentioned this pull request Jul 15, 2017
Merged
@stleary
Copy link
Owner

stleary commented Jul 15, 2017

What problem does this code solve?
Javadoc only update, no functional changes, OK to fast track.

Does it break the unit tests?
No. A backwards-compatible change was added to demo the documented behavior

Review status
ACCEPTED

@stleary stleary merged commit d345bc5 into stleary:master Jul 15, 2017
@johnjaylward johnjaylward deleted the WriteJavadocUpdate branch August 14, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnjaylward @stleary