Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #45

Merged
merged 2 commits into from
Jan 30, 2012
Merged

Testing #45

merged 2 commits into from
Jan 30, 2012

Conversation

guywithnose
Copy link
Contributor

I added an almost complete set of tests. I also fixed two bugs:

  1. Using Integer.MAX_VALUE in JSONTokener can cause memory issues.
    Refer to http://docs.oracle.com/javase/1.4.2/docs/api/java/io/BufferedReader.html#mark%28int%29
  2. Changed "==" to .equals() in JSONML

@douglascrockford
Copy link
Contributor

Thanks.

@douglascrockford
Copy link
Contributor

Could you please resubmit with this change:

if (!arrayForm && ("tagName".equals(attribute) || "childNode".equals(attribute))) {

@guywithnose
Copy link
Contributor Author

Done

douglascrockford added a commit that referenced this pull request Jan 30, 2012
@douglascrockford douglascrockford merged commit 92038ce into stleary:master Jan 30, 2012
BGehrels pushed a commit to BGehrels/JSON-java that referenced this pull request Apr 29, 2020
Added unit tests for escaped quotes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants