Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this code solve?
Simply standardizes error messages when data types don't match expected value types. I.e. someone tries to convert the string "bob" to an int value.
Risks
None.
Changes to the API?
No.
Will this require a new release?
Not immediately.
Should the documentation be updated?
No.
Does it break the unit tests?
Yes. There were corrections needed to match the new string values of the messages. See: stleary/JSON-Java-unit-test#95
Was any code refactored in this commit?
Yes. The exception code was pulled out to a common function similar to the
syntaxError
function used in the Tokeners.Review status
APPROVED