Unit test fixes #525
Merged
Unit test fixes #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- commented `java() {...}` within build.gradle
- added following files
1. gradlew
2. gradlew.bat (for windows)
3. gradle/wrapper/gradle-wrapper.properties (for ./gradlew command execution)
4. gradle/wrapper/gradle-wrapper.jar (for ./gradlew command execution)
|
@johnjaylward gradle-wrapper.properties specify gradle-6.3, but the test case was fixed in Java 1.7? Can you clarify? |
|
The test case was using a function that wasnt available until java8. I changed it to not use that function and instead use manual casting and addition |
|
APPROVED |
|
Yes, from my testing here: https://github.com/johnjaylward/JSON-java/actions you can see that most of the tests fail in Java7 due to comparison differences due to hash reordering. |
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this code solve?
Fixes #523
Risks
None. No changes to library code, just supporting items
Changes to the API?
No
Will this require a new release?
No
Should the documentation be updated?
No
Does it break the unit tests?
No
Was any code refactored in this commit?
Review status