-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Unit tests and supports GitHub Actions #527
Conversation
0682241
to
c11c006
Compare
Confirmed successful build and unit test with gradle 6.4, maven 3.2.3, Eclipse Luna, Java 1.8.0_05. |
Thanks, nice work. Will check GitHub actions on the next PR. |
You can see what it looks like now https://github.com/stleary/JSON-java/actions/runs/126495486 It ran the jobs after you merged |
I get that is runs on PR, but was not expecting it to run on merge:
|
With the It looks like github lets you create as many of these job files as you want, so you should be able to create one that triggers when a tag is created and then does the push to maven central for you. |
As a side note, the secret key for deployment would go in the project settings -> secrets area, which only you would have access to https://github.com/stleary/JSON-java/settings/secrets |
What problem does this code solve?
Fixes #523
Risks
LOW/None. Only Tests were corrected
Changes to the API?
No
Will this require a new release?
No
Should the documentation be updated?
No
Does it break the unit tests?
No, it fixes them
Was any code refactored in this commit?
Only Test cases to make the items being tested simpler to follow and verify.
Review status
APPROVED
No comment window this time