Bring Junit tests to Java 1.6 compatibility #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Starting 3-day comment window. |
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this code solve?
The project code is 1.6-compatible, but the unit tests require Java 1.7. This makes building and testing clumsy, and
can't be sure the lib works correctly in a Jave 1.6 environment. Remove diamond operators: <> and
autoclose expressions from several junit modules. Updated Maven pom.xml to use Java 1.6.
Confirmed that Maven (1.6) and Gradlew (1.8) build and test correctly.
Risks
No risk to production code, moderate risk to unit tests.
Changes to the API?
No
Will this require a new release?
No
Should the documentation be updated?
Yes - readme will need to be updated, but it's currently in review on another branch.
CI build will be updated on approval/merge, to add testing to the 1.6 build.
Does it break the unit tests?
No
Was any code refactored in this commit?
No
Review status
Approved - by myself