-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streams support #768
Closed
Streams support #768
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
252bfbb
streams - JSONObject and JSONArray implement iterable, add stream() m…
4cea301
streams - remove implements from JSONObject and JSONArray
c619419
Revert "streams - remove implements from JSONObject and JSONArray"
e4a3337
streams - implement meaningful iterator() for JSONObject. Also, fix g…
960b374
streams - comments and test
870b5f2
streams - removed unneeded overrides
22ac808
Unit tests for JSONArray stream()
4d0bb3a
streams - jsonobject stream implementation and unit tests
6e670d5
streams - cleanup unneeded test cases, refactor to remove warnings in…
9dac039
streams - code review action items
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is the best
Iterable<>
that could have been chosen.Would it make more sense to implement this closer to the
Map<>.entrySet()
? Something like:public class JSONObject implements Iterable<Map.Entry<String, Object>>
?Or maybe even better would be to keep it very similar to
Map<>
and not have it directly implementIterable<>
at all. Instead offer similar functions that theMap
interface does:keySet
entrySet
values
Each of those methods would return proper
Iterable
implementations.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation now streams entrySet() without Iterable<>.