Add optJSONArray method to JSONObject with a default value

[eedijs]

The JSONObject class had a missing optJSONArray method with a default return value, which is very useful in some cases, so you don't have to write code like this:

JSONArray jsonArray = jsonObject.has("key") ? jsonObject.getJSONArray("key") : new JSONArray;

And instead just write:

JSONArray jsonArray = jsonObject.optJSONArray("key", new JSONArray());

[stleary]

@eedijs Thanks, agree it should be possible to return a default value. Is there a reason why this method was not also added to JSONArray?

[eedijs]

@eedijs Thanks, agree it should be possible to return a default value. Is there a reason why this method was not also added to JSONArray?

Sorry, didn't even check the JSONArray class. Seems like it is also missing the optJSONObject method with a default value.

I will go over both JSONObject and JSONArray classes once more and see if anything else need an opt method with default values.

[stleary]

I think there's a good case to be made for optJSONArray() with default. Probably not necessary to do an exhaustive review of all of the opt methods.

[eedijs]

I think there's a good case to be made for optJSONArray() with default. Probably not necessary to do an exhaustive review of all of the opt methods.

Ok, I just commited optJSONArray and optJSONObject methods for the JSONArray class.

[stleary]

What problem does this code solve?
Opt methods for JSONArray and JSONObject should allow a default value to be returned.

Risks
Low

Changes to the API?
Yes, new API methods are added where a default parameter is included. The default param is the same type as the return value.

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No. New unit tests were added for the new API methods.

Was any code refactored in this commit?
No

Review status
APPROVED

Starting 3-day comment window