Upgrading to Gradle 8.3 #775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mccartney A detailed explanation for these changes is needed. |
johnjaylward
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
@stleary This looks like a fairly standard Gradle Wrapper update. The newer versions of Gradle support newer versions of Java but can still be run on Java 8 if needed.
In fact to support building for Java 17 (as we do with the maven build) we would need to upgrade to at least Gradle 7.3
https://docs.gradle.org/current/userguide/compatibility.html
|
Thanks for the PR, but not accepting a Gradle upgrade at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to Gradle 8.3 for no specific reason other than staying up to date.
This PR is the result of:
8.3instead of6.3gradlew wrapper