Fix XMLTest.testIndentComplicatedJsonObjectWithArrayAndWithConfig() for Windows - in the test

[Madjosz]

#593 and 85495fa included some workaround for Windows machines regarding linefeeds. The test org.json.junit.XMLTest.testIndentComplicatedJsonObjectWithArrayAndWithConfig() is currently failing on my Windows 10 machine and also I see no reason why this workaround was needed in the first place. The file Issue593.xml contains only \n line feeds and no conversion is done while reading this file, thus expected only contains \n. Conversely the tested method XML.toString() only appends hardcoded \n.

The only setting where the conversion is needed is when someone has their .gitattributes/Git settings or IDE configured to autoreplace linefeeds by the system default. In that case I would say it is actually correct that the test fails because it indicates a wrong setup.

[stleary]

@Madjosz Thanks for catching this! I had gotten out of the habit of testing on Windows.

[stleary]

@Madjosz I prefer this version of the fix, but I cannot test it locally, probably because of recent commits. You will need to fix this if you want your PR to be considered.

git pull https://github.com/Madjosz/JSON-java.git fix_xml_test
From https://github.com/Madjosz/JSON-java
* branch fix_xml_test -> FETCH_HEAD
fatal: Not possible to fast-forward, aborting.

Never mind, it's working now, but I had to run: git config pull.rebase false

[johnjaylward]

@stleary THE PR doesn't say there is a conflict. Are you sure you are on master when trying the pull?

[stleary]

What problem does this code solve?
Fixes a unit test that somehow became broken in Windows

Risks
Low

Changes to the API?
N/A

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
N/A

Was any code refactored in this commit?
N/A

Review status
APPROVED

Because of Hacktoberfest, both #782 and #778 will be accepted and merged, in that order.

Starting 3-day comment window

[Madjosz]

I rebased both branches ontop of the master for you.

[stleary]

@Madjosz Thanks, checkout and pull is working now.

The merge-base changed after approval.