Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add validity check for JSONObject constructors #779

Merged
merged 1 commit into from
Oct 8, 2023
Merged

add validity check for JSONObject constructors #779

merged 1 commit into from
Oct 8, 2023
+31 −3

Conversation

Madjosz
Copy link
Contributor

@Madjosz Madjosz commented Oct 4, 2023

@stleary
Copy link
Owner

stleary commented Oct 5, 2023

@Madjosz Your branch may be out of sync due to recent changes in JSONObjectTest.java.

@johnjaylward johnjaylward mentioned this pull request Oct 5, 2023
Closed
@stleary
Copy link
Owner

stleary commented Oct 5, 2023

What problem does this code solve?
Numeric inputs in JSONObject constructors should check for validity.

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, new unit tests were added

Was any code refactored in this commit?
A few minor refactorings unrelated to this commit are included.

Review status
APPROVED

Starting 3-day comment window

@Madjosz
add validity check for JSONObject constructors
c93014c 
* fixes stleary#713
* document JSONException in JavaDoc
* remove unused Comparable<T> boundary to reuse GenericBean in test
@Madjosz Madjosz force-pushed the 713_jsonobject_nonfinite branch from 43b2569 to c93014c Compare October 7, 2023 07:39
@stleary stleary merged commit c4cd526 into stleary:master Oct 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stleary stleary stleary approved these changes

@johnjaylward johnjaylward johnjaylward approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSONObject constructors do not check for non-finite numbers
3 participants
@Madjosz @stleary @johnjaylward