Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #701 track for circular dependency #785

Closed
wants to merge 1 commit into from

Conversation

ZachsCoffee
Copy link

@ZachsCoffee ZachsCoffee commented Oct 8, 2023

Fix for: #701
The IdentityHashMap will be used to track the instances that are wrapped. This we don't need to wait for the StackOverflowExcpetion to find out about the problem of circular dependency.

The functionality isn't new for the class the same solution is made at this constructor: org.json.JSONObject#JSONObject(java.lang.Object, java.util.Set<java.lang.Object>)

Please add the hacktoberfest-accepted label if we will proceed with the PR.

@stleary
Copy link
Owner

stleary commented Oct 8, 2023

Closing due to:

@stleary stleary closed this Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants