Cleanup warnings and merge new unit tests #846
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this code solve?
Notes:
Return type
T extends ParserConfiguration
is a clever design, but it seems to require suppressingUnchecked
warnings in the methods and overrides, resulting in a code smell. This was missed in the initial review. The design is not being changed at this time because it would require changes to existing API methods. If anyone has ideas about how to mitigate this without changing the API, please let me know.Does the code still compile with Java6?
Yes
Risks
Low
Changes to the API?
No
Will this require a new release?
No
Should the documentation be updated?
No
Does it break the unit tests?
No, some new tests were added
Was any code refactored in this commit?
Review status
APPROVED - by myself
Starting 3-day comment window