Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup warnings and merge new unit tests #846

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

stleary
Copy link
Owner

@stleary stleary commented Jan 1, 2024

What problem does this code solve?

  • Fixed some compiler warnings
    • Added @SuppressWarning annotations to ParserConfigurationo and derived class methods, as needed
    • Added descriptions as needed to param and return docstrings as needed
    • Added <> to ArrayList ctors in unit test WeirdList
    • Added unchecked warning flag to pom.xml for greater visibility of this warning
  • Pulled in unit tests from Add a config flag to disable whitespace trimming #832, lest they be lost

Notes:
Return type T extends ParserConfiguration is a clever design, but it seems to require suppressing Unchecked warnings in the methods and overrides, resulting in a code smell. This was missed in the initial review. The design is not being changed at this time because it would require changes to existing API methods. If anyone has ideas about how to mitigate this without changing the API, please let me know.

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, some new tests were added

Was any code refactored in this commit?

Review status
APPROVED - by myself

Starting 3-day comment window

@stleary stleary changed the title Cleanup and merge tests Cleanup warnings and merge new unit tests Jan 1, 2024
@stleary stleary merged commit 55b824d into master Jan 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant