Added try-catch to notification close in symbol destructor #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1717174302
💛 - Coveralls |
stlehmann
requested changes
Jan 18, 2022
RobertoRoos
force-pushed
the
bugfix/adssymbol_del
branch
from
d5336fb to
841fd39
Compare
RobertoRoos
force-pushed
the
bugfix/adssymbol_del
branch
from
841fd39 to
6a1d656
Compare
|
@RobertoRoos do you think you can find a way to add a test for this particular case? |
chrisbeardy
added a commit
that referenced
this pull request
Jul 30, 2024
…symbol destructor) (#369) * Added try-catch to notification close in symbol destructor * Add test for try-catch to notification close in symbol destructor * Update changelog * More elegant way to test for error not raised. Use self.fail() now instead of self.assert(). Thanks to @RobtertoRoos for pointing it out. --------- Co-authored-by: Roberto-R <robert.soor@gmail.com> Co-authored-by: chrisbeardy <20585410+chrisbeardy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #303