Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shamelessly copy DMA implementation from stm32f1xx-hal crate. #123

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

matoushybl
Copy link
Contributor

This PR adds DMA interface created using embedded-dma traits, that was copied from the stm32f1xx-hal crate and adapted for the needs of STM32F0 controller line.

DMA2 for STM32F091 was not yet added as to my understanding it requires some special handling.

@therealprof
Copy link
Member

Very nice! Obviously needs some more work though. I'd probably split out the stm32f0 bump to see whether there's any fallout from that upgrade (and fix it) before adding DMA.

@matoushybl
Copy link
Contributor Author

Good idea, I’ll make a separate PR for updating dependencies and have a look at the failing CI.

@therealprof
Copy link
Member

bors try

@bors
Copy link
Contributor

bors bot commented Nov 14, 2020

try

Merge conflict.

@matoushybl
Copy link
Contributor Author

Hi, the PR still doesn't pass CI as the f1xx-hal uses #[non_exhaustive] feature on enums and they do not specify the minimum supported Rust version. I think that we shouldn't specify the MSRV as of now, since this HAL implementation is very limited and I am willing to start working on it and bring it up to the at least the same level as the other HALs and fixed MSRV could potentionaly cripple the development. What do you think @therealprof ?

Removing he non_exhaustive attribute is not a problem, but it would break the cross HAL compatibility.

@therealprof
Copy link
Member

I'm not a big fan of MSRV in general. Let's just bump the version in CI.

@matoushybl
Copy link
Contributor Author

Ok, I'll make the PR when I have time in a few days. Should I remove checking against some specific rust version in general or just bump the specified version to a current Rust version?

What about the timing out bors? Do you have any idea why it fails? Fix for it could also be a part of that PR.

@matoushybl matoushybl force-pushed the feature/dma branch 2 times, most recently from f897726 to 7454fca Compare November 20, 2020 07:21
@therealprof
Copy link
Member

Any updates here? Can you add an example using DMA?

Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please add a CHANGELOG entry and an example?

@matoushybl
Copy link
Contributor Author

@therealprof Sorry for ignoring my PRs and you, I am a bit busy and don't develop on F0 often nowadays. I have the work on these PRs on my TODO list and will get back to them when I have a bit more time - unfortunately in June.

@therealprof
Copy link
Member

No worries, I can totally relate. Busy times with unrelated things for me as well...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants